Claude review: fbdev/hga: Request memory region before ioremap

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Positive aspects:**
- Correctly identifies that `ioremap()` at `0xb0000` is called without a preceding `request_mem_region()`.
- Properly adds `release_mem_region()` in the `ioremap()` failure path, the `error:` goto label, and in `hgafb_remove()`.

**Issue: Ordering in `error:` cleanup path**

In the `error:` label, the patch adds `release_mem_region()` *before* the existing `iounmap(hga_vram)` call at line 356 of the current source. Looking at the existing error path (lines 350-361):

```c
error:
	release_mem_region(0xb0000, hga_vram_len);  // added by patch
	if (release_io_ports)
		release_region(0x3b0, 12);
	if (release_io_port)
		release_region(0x3bf, 1);

	iounmap(hga_vram);
```

The `iounmap()` should happen *before* `release_mem_region()` — you should unmap the virtual mapping before releasing the underlying physical region. While in practice this is unlikely to cause a problem on x86 ISA hardware, the correct teardown order is the reverse of the setup order: `iounmap()` first, then `release_mem_region()`. The patch should place `release_mem_region()` after the `iounmap()` call, or better yet, after all existing cleanup in the error path (mirroring the order in `hgafb_remove()`).

Looking at `hgafb_remove()` (line 621-627 in current source), the patch correctly places `release_mem_region()` after `iounmap(hga_vram)`, which is the right order. The `error:` path should match this ordering.

**Minor style nit:**

The `pr_err` format string uses a `"hgafb: "` prefix manually. The driver could use `pr_fmt` or `dev_err` for consistent prefixing, but this is consistent with the existing style in this driver (see line 358: `pr_err("hgafb: HGA card not detected.\n")`), so it's acceptable.

**Summary:** The patch is a valid improvement but the teardown ordering in the `error:` goto path should be fixed so that `release_mem_region()` comes after `iounmap()`, consistent with the ordering in `hgafb_remove()`.

---
Generated by Claude Code Patch Reviewer