From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: rockchip: analogix-dp: Add support for RK3576
Date: Wed, 11 Mar 2026 13:27:10 +1000 [thread overview]
Message-ID: <review-patch1-20260310105307.309765-2-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260310105307.309765-2-damon.ding@rock-chips.com>
Patch Review
**Clock-names binding change is problematic.** The patch changes the third clock-name from a fixed `const: grf` to an `enum: [grf, hclk]`:
```yaml
- - const: grf
+ - enum:
+ - grf
+ - hclk
```
This is a semantic change that affects **all** existing compatibles, not just the new RK3576 one. The RK3288 uses a `grf` clock, and now the schema would also allow `hclk` for RK3288, which doesn't make sense. This should instead be handled with a per-compatible conditional (in the `allOf` section), similar to how the reset constraints are already conditional. For example, add an `if`/`then` block that constrains clock-names for RK3576 to `[dp, pclk, hclk]` and keeps the existing behavior for other compatibles.
Alternatively, since RK3576 uses `hclk` and RK3288 uses `grf` as the third clock, consider restructuring the items list to use `oneOf` or per-compatible `clock-names` constraints.
**The cover letter says "The newly added clock 'hclk' is the video datapath clock"** — this description should be in the binding document itself (in the items description or the property description), not just the commit message.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 3:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 10:53 [PATCH v1 0/4] Add eDP support for RK3576 Damon Ding
2026-03-10 10:53 ` [PATCH v1 1/4] dt-bindings: display: rockchip: analogix-dp: Add " Damon Ding
2026-03-11 3:27 ` Claude Code Review Bot [this message]
2026-03-10 10:53 ` [PATCH v1 2/4] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-03-11 3:27 ` Claude review: " Claude Code Review Bot
2026-03-10 10:53 ` [PATCH v1 3/4] drm/bridge: analogix_dp: Add support " Damon Ding
2026-03-11 3:27 ` Claude review: " Claude Code Review Bot
2026-03-10 10:53 ` [PATCH v1 4/4] drm/rockchip: " Damon Ding
2026-03-11 3:27 ` Claude review: " Claude Code Review Bot
2026-03-10 11:11 ` [PATCH v1 0/4] Add eDP " Damon Ding
2026-03-11 3:27 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 10:40 [PATCH v2 0/9] " Damon Ding
2026-03-19 10:40 ` [PATCH v2 5/9] dt-bindings: display: rockchip: analogix-dp: Add " Damon Ding
2026-03-21 18:26 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260310105307.309765-2-damon.ding@rock-chips.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox