public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: Restore widebus calculation for CMDMode panels
Date: Fri, 13 Mar 2026 14:40:21 +1000	[thread overview]
Message-ID: <review-patch1-20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org> (raw)
In-Reply-To: <20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org>

Patch Review

**Correctness: The fix is sound.** The commit message clearly explains the regression and why the removed check was necessary. The code change correctly restores the `bits_per_pclk = 48` path for command-mode DSC panels with widebus:

```c
-		if (wide_bus_enabled)
-			bits_per_pclk = mipi_dsi_pixel_format_to_bpp(msm_host->format);
-		else
+		if (wide_bus_enabled) {
+			if (msm_host->mode_flags & MIPI_DSI_MODE_VIDEO)
+				bits_per_pclk = mipi_dsi_pixel_format_to_bpp(msm_host->format);
+			else
+				bits_per_pclk = 48;
+		} else {
 			bits_per_pclk = 24;
+		}
```

**Minor observations:**

1. **Video-mode widebus path questionable (noted by author):** The author rightly questions in the cover notes whether `mipi_dsi_pixel_format_to_bpp()` makes sense for the video-mode widebus path — for RGB888 it returns 24, which is the same as the non-widebus case. This means widebus is still effectively a no-op for video mode DSC panels. However, this patch is correct in not trying to fix that — it's a minimal regression fix that restores the working CMD mode path without changing the (possibly still broken) video mode behavior.

2. **Commit message typo:** Line 99 says "add back the path allows" — should read "add back the path **that** allows".

3. **drm-next divergence:** As noted above, the drm-next tree at `dsi_host.c:1030-1033` already has:
   ```c
   if (wide_bus_enabled && !(msm_host->mode_flags & MIPI_DSI_MODE_VIDEO))
       bytes_per_pclk = 6;
   else
       bytes_per_pclk = 3;
   ```
   This is functionally equivalent to the fix (6 bytes = 48 bits, 3 bytes = 24 bits for CMD mode), and also doesn't apply `mipi_dsi_pixel_format_to_bpp()` for video mode at all. The maintainers should clarify whether this patch is intended for a stable branch where the intermediate refactoring hasn't been applied.

**Verdict:** The fix is correct and well-motivated. The only action item is the minor typo in the commit message and clarifying the target tree/branch.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-13  4:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 22:31 [PATCH] drm/msm/dsi: Restore widebus calculation for CMDMode panels Marijn Suijten
2026-03-12  5:10 ` Pengyu Luo
2026-03-12 13:18 ` AngeloGioacchino Del Regno
2026-03-12 23:08   ` Marijn Suijten
2026-03-13  4:40 ` Claude review: " Claude Code Review Bot
2026-03-13  4:40 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox