From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dsi: Restore widebus calculation for CMDMode panels Date: Fri, 13 Mar 2026 14:40:21 +1000 Message-ID: In-Reply-To: <20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org> References: <20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org> <20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: The fix is sound.** The commit message clearly explains the = regression and why the removed check was necessary. The code change correct= ly restores the `bits_per_pclk =3D 48` path for command-mode DSC panels wit= h widebus: ```c - if (wide_bus_enabled) - bits_per_pclk =3D mipi_dsi_pixel_format_to_bpp(msm_host->format); - else + if (wide_bus_enabled) { + if (msm_host->mode_flags & MIPI_DSI_MODE_VIDEO) + bits_per_pclk =3D mipi_dsi_pixel_format_to_bpp(msm_host->format); + else + bits_per_pclk =3D 48; + } else { bits_per_pclk =3D 24; + } ``` **Minor observations:** 1. **Video-mode widebus path questionable (noted by author):** The author r= ightly questions in the cover notes whether `mipi_dsi_pixel_format_to_bpp()= ` makes sense for the video-mode widebus path =E2=80=94 for RGB888 it retur= ns 24, which is the same as the non-widebus case. This means widebus is sti= ll effectively a no-op for video mode DSC panels. However, this patch is co= rrect in not trying to fix that =E2=80=94 it's a minimal regression fix tha= t restores the working CMD mode path without changing the (possibly still b= roken) video mode behavior. 2. **Commit message typo:** Line 99 says "add back the path allows" =E2=80= =94 should read "add back the path **that** allows". 3. **drm-next divergence:** As noted above, the drm-next tree at `dsi_host.= c:1030-1033` already has: ```c if (wide_bus_enabled && !(msm_host->mode_flags & MIPI_DSI_MODE_VIDEO)) bytes_per_pclk =3D 6; else bytes_per_pclk =3D 3; ``` This is functionally equivalent to the fix (6 bytes =3D 48 bits, 3 bytes= =3D 24 bits for CMD mode), and also doesn't apply `mipi_dsi_pixel_format_t= o_bpp()` for video mode at all. The maintainers should clarify whether this= patch is intended for a stable branch where the intermediate refactoring h= asn't been applied. **Verdict:** The fix is correct and well-motivated. The only action item is= the minor typo in the commit message and clarifying the target tree/branch. --- Generated by Claude Code Patch Reviewer