From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Drop extra drm_mode_config_reset() call Date: Thu, 12 Mar 2026 07:12:05 +1000 Message-ID: In-Reply-To: <20260311-tidss-minor-fixes-v1-1-ee5e6e14a566@ideasonboard.com> References: <20260311-tidss-minor-fixes-v1-0-ee5e6e14a566@ideasonboard.com> <20260311-tidss-minor-fixes-v1-1-ee5e6e14a566@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Reviewed-by worthy.** The fix is correct and trivially verifiable. The probe path calls `drm_mode_config_reset()` twice: 1. In `tidss_modeset_init()` at `tidss_kms.c:290` 2. In `tidss_probe()` at `tidss_drv.c:174` The patch removes the first call (in `tidss_kms.c`), keeping the one in `ti= dss_drv.c:174` which runs later =E2=80=94 after `tidss_irq_install()` and `= drm_kms_helper_poll_init()`. This is the better one to keep, as it's the fi= nal reset before `drm_dev_register()`. No issues found. --- Generated by Claude Code Patch Reviewer