From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tidss: Drop extra drm_mode_config_reset() call
Date: Thu, 12 Mar 2026 07:10:39 +1000 [thread overview]
Message-ID: <review-patch1-20260311-tidss-minor-fixes-v2-1-cb4479784458@ideasonboard.com> (raw)
In-Reply-To: <20260311-tidss-minor-fixes-v2-1-cb4479784458@ideasonboard.com>
Patch Review
**Status: Looks good.**
The patch removes `drm_mode_config_reset(ddev)` from `tidss_kms.c` (`tidss_modeset_init()`). Checking the kernel tree confirms there are currently two calls:
- `tidss_kms.c:290` — inside `tidss_modeset_init()` (the one being removed)
- `tidss_drv.c:174` — in the probe path, called *after* `tidss_modeset_init()` returns
Since `tidss_drv.c:174` runs later (after `drm_kms_helper_poll_init()` and before `drm_dev_register()`), the earlier call in `tidss_kms.c` is indeed redundant — the state will just get reset again. Removing it is correct and the Fixes tag to the original driver commit is appropriate.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 9:14 [PATCH v2 0/2] drm/tidss: Two minor fixes Tomi Valkeinen
2026-03-11 9:14 ` [PATCH v2 1/2] drm/tidss: Drop extra drm_mode_config_reset() call Tomi Valkeinen
2026-03-11 21:10 ` Claude Code Review Bot [this message]
2026-03-11 9:14 ` [PATCH v2 2/2] drm/tidss: Fix missing drm_bridge_add() call Tomi Valkeinen
2026-03-11 21:10 ` Claude review: " Claude Code Review Bot
2026-03-11 21:10 ` Claude review: drm/tidss: Two minor fixes Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-11 8:16 [PATCH 0/2] " Tomi Valkeinen
2026-03-11 8:16 ` [PATCH 1/2] drm/tidss: Drop extra drm_mode_config_reset() call Tomi Valkeinen
2026-03-11 21:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260311-tidss-minor-fixes-v2-1-cb4479784458@ideasonboard.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox