From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Drop extra drm_mode_config_reset() call Date: Thu, 12 Mar 2026 07:10:39 +1000 Message-ID: In-Reply-To: <20260311-tidss-minor-fixes-v2-1-cb4479784458@ideasonboard.com> References: <20260311-tidss-minor-fixes-v2-0-cb4479784458@ideasonboard.com> <20260311-tidss-minor-fixes-v2-1-cb4479784458@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good.** The patch removes `drm_mode_config_reset(ddev)` from `tidss_kms.c` (`tidss_= modeset_init()`). Checking the kernel tree confirms there are currently two= calls: - `tidss_kms.c:290` =E2=80=94 inside `tidss_modeset_init()` (the one being = removed) - `tidss_drv.c:174` =E2=80=94 in the probe path, called *after* `tidss_mode= set_init()` returns Since `tidss_drv.c:174` runs later (after `drm_kms_helper_poll_init()` and = before `drm_dev_register()`), the earlier call in `tidss_kms.c` is indeed r= edundant =E2=80=94 the state will just get reset again. Removing it is corr= ect and the Fixes tag to the original driver commit is appropriate. No issues. --- Generated by Claude Code Patch Reviewer