From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mipi-dbi: Only modify planes on enabled CRTCs Date: Thu, 12 Mar 2026 07:03:36 +1000 Message-ID: In-Reply-To: <20260311101438.365997-2-tzimmermann@suse.de> References: <20260311101438.365997-1-tzimmermann@suse.de> <20260311101438.365997-2-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Switches from `drm_atomic_helper_commit_tail()` to `drm_atomic_helper_commit_tail_rpm()`, which enables the CRTC before updating planes. This allows removing the redundant framebuffer flush from `mipi_dbi_enable_flush()` (and custom equivalents in ili9225/st7586). The remaining backlight enable is inlined into each driver. The change is well-motivated and correct. The new mode config helper funcs: ```c static const struct drm_mode_config_helper_funcs mipi_dbi_mode_config_helper_funcs = { .atomic_commit_tail = drm_atomic_helper_commit_tail_rpm, }; ``` No issues found. The ili9225 driver correctly drops its `ili9225_fb_dirty()` call without adding `backlight_enable()` since it doesn't use a backlight. The st7586 custom dirty function is still correctly invoked through the plane update path. --- Generated by Claude Code Patch Reviewer