From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/drm_ras: Add clear-error-counter netlink command to drm_ras
Date: Thu, 12 Mar 2026 07:06:12 +1000 [thread overview]
Message-ID: <review-patch1-20260311102913.3387468-7-riana.tauro@intel.com> (raw)
In-Reply-To: <20260311102913.3387468-7-riana.tauro@intel.com>
Patch Review
Overall a clean patch. The YAML spec, documentation, and uapi additions look correct.
**Concurrency concern in `drm_ras_nl_clear_error_counter_doit`:**
```c
node = xa_load(&drm_ras_xa, node_id);
if (!node || !node->clear_error_counter)
return -ENOENT;
```
The same concern likely exists in the pre-existing `get_error_counter` paths, but there is no locking or RCU protection around the `xa_load` + subsequent use of `node`. If a node is unregistered concurrently, this could use-after-free. This is a pre-existing design issue, but adding a new operation makes it worth mentioning. Consider using `xa_lock`/`xa_unlock` or RCU to protect node lifetime.
**Return value for unsupported clear operation:**
```c
if (!node || !node->clear_error_counter)
return -ENOENT;
```
Returning `-ENOENT` when `clear_error_counter` is NULL (i.e., the node exists but doesn't support clearing) is slightly misleading. `-EOPNOTSUPP` would be more appropriate when the node exists but the operation is not implemented.
**YAML anchor reuse is a nice touch:**
```yaml
attributes: &id-attrs
- node-id
- error-id
```
Using `&id-attrs` / `*id-attrs` to avoid duplicating the attribute list is good.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 21:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 10:29 [PATCH 0/4] Add support for clear counter and error event in DRM RAS Riana Tauro
2026-03-11 10:29 ` [PATCH 1/4] drm/drm_ras: Add clear-error-counter netlink command to drm_ras Riana Tauro
2026-03-11 21:06 ` Claude Code Review Bot [this message]
2026-03-11 10:29 ` [PATCH 2/4] drm/xe/xe_drm_ras: Add support for clear-error-counter in XE DRM RAS Riana Tauro
2026-03-11 21:06 ` Claude review: " Claude Code Review Bot
2026-03-11 10:29 ` [PATCH 3/4] drm/drm_ras: Add DRM RAS netlink error event notification Riana Tauro
2026-03-11 21:06 ` Claude review: " Claude Code Review Bot
2026-03-11 10:29 ` [PATCH 4/4] drm/xe/xe_drm_ras: Add error-event support in XE DRM RAS Riana Tauro
2026-03-11 21:06 ` Claude review: " Claude Code Review Bot
2026-03-11 21:06 ` Claude review: Add support for clear counter and error event in " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260311102913.3387468-7-riana.tauro@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox