From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/radeon: fix __user annotation in radeon_info_ioctl() Date: Thu, 12 Mar 2026 06:51:40 +1000 Message-ID: In-Reply-To: <20260311142138.530006-1-ben.dooks@codethink.co.uk> References: <20260311142138.530006-1-ben.dooks@codethink.co.uk> <20260311142138.530006-1-ben.dooks@codethink.co.uk> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Clean** The patch makes two changes: 1. **Declaration split** =E2=80=94 Separates `value_ptr` from the other `ui= nt32_t` locals and gives it `__user`: ```c - uint32_t *value, value_tmp, *value_ptr, value_size; + uint32_t *value, value_tmp, value_size; + uint32_t __user *value_ptr; ``` 2. **Cast annotation** =E2=80=94 Adds `__user` to the cast where `value_ptr= ` is assigned from `info->value`: ```c - value_ptr =3D (uint32_t *)((unsigned long)info->value); + value_ptr =3D (uint32_t __user *)((unsigned long)info->value); ``` Both changes are correct. `value_ptr` is used in six places in the function= =E2=80=94 five `copy_from_user()` calls and one `copy_to_user()` call =E2= =80=94 all of which expect a `__user` pointer. The fix eliminates all six s= parse warnings listed in the commit message. No functional change, no risk. Reviewed-by worthy. --- Generated by Claude Code Patch Reviewer