From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Fix gamma 2.2 colorop TFs
Date: Fri, 13 Mar 2026 14:43:47 +1000 [thread overview]
Message-ID: <review-patch1-20260311211837.2482799-1-alex.hung@amd.com> (raw)
In-Reply-To: <20260311211837.2482799-1-alex.hung@amd.com>
Patch Review
**Correctness: Good.** The three swaps are all consistent with the established pattern of the other TFs in each list:
1. `amdgpu_dm_supported_degam_tfs`: `GAMMA22_INV` → `GAMMA22` — degamma linearizes, so it needs the forward (EOTF-like) curve, matching `SRGB_EOTF` and `PQ_125_EOTF` already in the list.
2. `amdgpu_dm_supported_shaper_tfs`: `GAMMA22` → `GAMMA22_INV` — shaper de-linearizes, so it needs the inverse curve, matching `SRGB_INV_EOTF` and `PQ_125_INV_EOTF` already in the list.
3. `amdgpu_dm_supported_blnd_tfs`: `GAMMA22_INV` → `GAMMA22` — blend linearizes (same direction as degamma), consistent with the identical set of other TFs shared with degamma.
**Minor nit on the commit message:** The body says "Use GAMMA22 for degamma/blend and GAMMA22_INV for shaper so curves match the color pipeline" — this is accurate and concise but could benefit from a brief note about *why* the previous assignment was wrong (the forward/inverse were swapped). This is purely a style suggestion and not blocking.
**Reviewed-by worthy.** The patch has a clear bug report link, a `Tested-by` from the reporter, and the fix is mechanically obvious once you understand the EOTF/OETF naming convention. No further issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-13 4:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 21:18 [PATCH] drm/amd/display: Fix gamma 2.2 colorop TFs Alex Hung
2026-03-12 22:35 ` Melissa Wen
2026-03-13 4:43 ` Claude review: " Claude Code Review Bot
2026-03-13 4:43 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260311211837.2482799-1-alex.hung@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox