From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Fix gamma 2.2 colorop TFs Date: Fri, 13 Mar 2026 14:43:47 +1000 Message-ID: In-Reply-To: <20260311211837.2482799-1-alex.hung@amd.com> References: <20260311211837.2482799-1-alex.hung@amd.com> <20260311211837.2482799-1-alex.hung@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The three swaps are all consistent with the establis= hed pattern of the other TFs in each list: 1. `amdgpu_dm_supported_degam_tfs`: `GAMMA22_INV` =E2=86=92 `GAMMA22` =E2= =80=94 degamma linearizes, so it needs the forward (EOTF-like) curve, match= ing `SRGB_EOTF` and `PQ_125_EOTF` already in the list. 2. `amdgpu_dm_supported_shaper_tfs`: `GAMMA22` =E2=86=92 `GAMMA22_INV` =E2= =80=94 shaper de-linearizes, so it needs the inverse curve, matching `SRGB_= INV_EOTF` and `PQ_125_INV_EOTF` already in the list. 3. `amdgpu_dm_supported_blnd_tfs`: `GAMMA22_INV` =E2=86=92 `GAMMA22` =E2=80= =94 blend linearizes (same direction as degamma), consistent with the ident= ical set of other TFs shared with degamma. **Minor nit on the commit message:** The body says "Use GAMMA22 for degamma= /blend and GAMMA22_INV for shaper so curves match the color pipeline" =E2= =80=94 this is accurate and concise but could benefit from a brief note abo= ut *why* the previous assignment was wrong (the forward/inverse were swappe= d). This is purely a style suggestion and not blocking. **Reviewed-by worthy.** The patch has a clear bug report link, a `Tested-by= ` from the reporter, and the fix is mechanically obvious once you understan= d the EOTF/OETF naming convention. No further issues found. --- Generated by Claude Code Patch Reviewer