public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu/discovery: Add braces to case statements in amdgpu_discovery_table_check()
Date: Fri, 13 Mar 2026 13:44:39 +1000	[thread overview]
Message-ID: <review-patch1-20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org> (raw)
In-Reply-To: <20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org>

Patch Review

**Correctness:** The fix is textbook correct. Each of the five `case` labels (`IP_DISCOVERY`, `GC`, `HARVEST_INFO`, `VCN_INFO`, `MALL_INFO`) that declares a local variable immediately after the label is wrapped with `{ ... }` braces. The opening brace is placed after the colon on the `case` line, and the closing brace is placed before the next `case` (or `default`). Each case already ends with `break;`, so the braces don't change control flow.

**Commit message:** Excellent. Clearly explains the problem (clang with `-fms-anonymous-structs` instead of `-fms-extensions`), references the triggering commit (`47ab777c16c7`), provides the exact compiler error messages, links to the relevant linux-next commit enabling the new flag, and has a proper `Fixes:` tag.

**Style:** The brace placement follows kernel coding style. The diff is minimal — only 10 insertions and 5 deletions, all purely mechanical.

**No issues found.** This is a clean, minimal compiler-compatibility fix with no functional change.

Reviewed-by: AI Reviewer (automated)

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13  3:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 21:46 [PATCH] drm/amdgpu/discovery: Add braces to case statements in amdgpu_discovery_table_check() Nathan Chancellor
2026-03-13  3:44 ` Claude Code Review Bot [this message]
2026-03-13  3:44 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox