From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu/discovery: Add braces to case statements in amdgpu_discovery_table_check() Date: Fri, 13 Mar 2026 13:44:39 +1000 Message-ID: In-Reply-To: <20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org> References: <20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org> <20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The fix is textbook correct. Each of the five `case` label= s (`IP_DISCOVERY`, `GC`, `HARVEST_INFO`, `VCN_INFO`, `MALL_INFO`) that decl= ares a local variable immediately after the label is wrapped with `{ ... }`= braces. The opening brace is placed after the colon on the `case` line, an= d the closing brace is placed before the next `case` (or `default`). Each c= ase already ends with `break;`, so the braces don't change control flow. **Commit message:** Excellent. Clearly explains the problem (clang with `-f= ms-anonymous-structs` instead of `-fms-extensions`), references the trigger= ing commit (`47ab777c16c7`), provides the exact compiler error messages, li= nks to the relevant linux-next commit enabling the new flag, and has a prop= er `Fixes:` tag. **Style:** The brace placement follows kernel coding style. The diff is min= imal =E2=80=94 only 10 insertions and 5 deletions, all purely mechanical. **No issues found.** This is a clean, minimal compiler-compatibility fix wi= th no functional change. Reviewed-by: AI Reviewer (automated) --- Generated by Claude Code Patch Reviewer