From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dpu: Extract plane splitting into a dedicated function
Date: Fri, 13 Mar 2026 14:21:22 +1000 [thread overview]
Message-ID: <review-patch1-20260312-msm-next-quad-pipe-split-v19-1-4ffa2b06c996@linaro.org> (raw)
In-Reply-To: <20260312-msm-next-quad-pipe-split-v19-1-4ffa2b06c996@linaro.org>
Patch Review
**Review: Low-risk refactor, looks correct.**
This patch extracts the plane-splitting logic (src/dst rect computation, wide-plane splitting) from `dpu_plane_atomic_check_nosspp()` into a new `dpu_plane_split()` function. The `needs_qos_remap` assignment stays in the check function while rect manipulation moves to the new function.
The extraction is clean. Both `dpu_plane_atomic_check()` and `dpu_plane_virtual_atomic_check()` now call `dpu_plane_split()` after `dpu_plane_atomic_check_nosspp()`. The ordering is preserved — validation first, then splitting.
One minor observation: the old comment `/* move the assignment here, to ease handling to another pairs later */` is carried over verbatim into the new function. This comment made sense in the original context but is a bit stale now. Not blocking.
Has Reviewed-by from Dmitry Baryshkov. **No issues found.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 8:28 [PATCH v19 0/4] drm/msm/dpu: Support quad pipe with dual-interface Jun Nie
2026-03-12 8:28 ` [PATCH v19 1/4] drm/msm/dpu: Extract plane splitting into a dedicated function Jun Nie
2026-03-13 4:21 ` Claude Code Review Bot [this message]
2026-03-12 8:28 ` [PATCH v19 2/4] drm/msm/dpu: Defer SSPP allocation until CRTC check Jun Nie
2026-03-13 4:21 ` Claude review: " Claude Code Review Bot
2026-03-12 8:28 ` [PATCH v19 3/4] drm/msm/dpu: support plane splitting in quad-pipe case Jun Nie
2026-03-13 4:21 ` Claude review: " Claude Code Review Bot
2026-03-12 8:28 ` [PATCH v19 4/4] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case Jun Nie
2026-03-13 4:21 ` Claude review: " Claude Code Review Bot
2026-03-13 4:21 ` Claude review: drm/msm/dpu: Support quad pipe with dual-interface Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260312-msm-next-quad-pipe-split-v19-1-4ffa2b06c996@linaro.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox