From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dpu: Extract plane splitting into a dedicated function Date: Fri, 13 Mar 2026 14:21:22 +1000 Message-ID: In-Reply-To: <20260312-msm-next-quad-pipe-split-v19-1-4ffa2b06c996@linaro.org> References: <20260312-msm-next-quad-pipe-split-v19-0-4ffa2b06c996@linaro.org> <20260312-msm-next-quad-pipe-split-v19-1-4ffa2b06c996@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Review: Low-risk refactor, looks correct.** This patch extracts the plane-splitting logic (src/dst rect computation, wi= de-plane splitting) from `dpu_plane_atomic_check_nosspp()` into a new `dpu_= plane_split()` function. The `needs_qos_remap` assignment stays in the chec= k function while rect manipulation moves to the new function. The extraction is clean. Both `dpu_plane_atomic_check()` and `dpu_plane_vir= tual_atomic_check()` now call `dpu_plane_split()` after `dpu_plane_atomic_c= heck_nosspp()`. The ordering is preserved =E2=80=94 validation first, then = splitting. One minor observation: the old comment `/* move the assignment here, to eas= e handling to another pairs later */` is carried over verbatim into the new= function. This comment made sense in the original context but is a bit sta= le now. Not blocking. Has Reviewed-by from Dmitry Baryshkov. **No issues found.** --- Generated by Claude Code Patch Reviewer