From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/mdss: correct UBWC programming sequences
Date: Fri, 13 Mar 2026 14:12:48 +1000 [thread overview]
Message-ID: <review-patch1-20260312-ubwc-rework-v3-1-b7e8f800176a@oss.qualcomm.com> (raw)
In-Reply-To: <20260312-ubwc-rework-v3-1-b7e8f800176a@oss.qualcomm.com>
Patch Review
Correctly reworks UBWC setup to dispatch based on `REG_MDSS_HW_VERSION` instead of `ubwc_dec_version`. The renaming from `msm_mdss_setup_ubwc_dec_XX` to `msm_mdss_Nx_setup_ubwc` makes the intent clear. The `MDSS_HW_VER` macro is well-defined.
The swizzle masking with `& 0x1` in `msm_mdss_4x_setup_ubwc` correctly limits to level 1 for MDSS 4.x hardware. The bank_spread removal from the 4x path is correct since MDSS 4.x doesn't have that register bit.
**Note:** The old code had explicit error handling for unknown UBWC decoder versions (`default:` case with `dev_err`). The new code silently does nothing for MDSS < 4.0 with the comment `/* else UBWC 1.0 or none, no params to program */`. This loses diagnostics for truly unknown hardware, which is a minor tradeoff.
No bugs. Looks correct.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:12 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 13:29 [PATCH v3 00/27] soc/qcom/ubwc: rework UBWC configuration database Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 01/27] drm/msm/mdss: correct UBWC programming sequences Dmitry Baryshkov
2026-03-13 4:12 ` Claude Code Review Bot [this message]
2026-03-12 13:29 ` [PATCH v3 02/27] soc: qcom: ubwc: define UBWC 3.1 Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 03/27] soc: qcom: ubwc: define helper for MDSS and Adreno drivers Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 04/27] soc: qcom: ubwc: add helper controlling AMSBC enablement Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 05/27] drm/msm/adreno: Trust the SSoT UBWC config Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 06/27] drm/msm/adreno: use qcom_ubwc_version_tag() helper Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 07/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 08/27] drm/msm/adreno: use new helper to set min_acc length Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 09/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 10/27] drm/msm/adreno: use new helper to set macrotile_mode Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 11/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 12/27] drm/msm/mdss: use new helper to set UBWC bank spreading Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 13/27] drm/msm/adreno: use new helper to set ubwc_swizzle Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 14/27] drm/msm/dpu: " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 15/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 16/27] drm/msm/adreno: use new helper to set amsbc Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 17/27] drm/msm/mdss: " Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 18/27] drm/msm/dpu: drop ubwc_dec_version Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 19/27] drm/msm/dpu: invert the order of UBWC checks Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 20/27] drm/msm/adreno: adapt for UBWC 3.1 support Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 21/27] soc: qcom: ubwc: set min_acc length to 64 for all UBWC 1.0 targets Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 22/27] soc: qcom: ubwc: drop ubwc_dec_version Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 23/27] soc: qcom: ubwc: drop ubwc_bank_spread Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 24/27] soc: qcom: ubwc: drop macrotile_mode from the database Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 25/27] soc: qcom: ubwc: use fixed values for UBWC swizzle for UBWC < 4.0 Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 26/27] soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-12 13:29 ` [PATCH v3 27/27] soc: qcom: ubwc: deduplicate UBWC configuration data Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
2026-03-13 4:12 ` Claude review: soc/qcom/ubwc: rework UBWC configuration database Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-11 3:22 [PATCH v2 00/25] " Dmitry Baryshkov
2026-03-11 3:22 ` [PATCH v2 01/25] drm/msm/mdss: correct UBWC programming sequences Dmitry Baryshkov
2026-03-11 21:21 ` Claude review: " Claude Code Review Bot
2026-03-06 16:47 [PATCH 00/24] soc/qcom/ubwc: rework UBWC configuration database Dmitry Baryshkov
2026-03-06 16:47 ` [PATCH 01/24] drm/msm/mdss: correct UBWC programming sequences Dmitry Baryshkov
2026-03-08 22:32 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260312-ubwc-rework-v3-1-b7e8f800176a@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox