From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/mdss: correct UBWC programming sequences Date: Fri, 13 Mar 2026 14:12:48 +1000 Message-ID: In-Reply-To: <20260312-ubwc-rework-v3-1-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-1-b7e8f800176a@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Correctly reworks UBWC setup to dispatch based on `REG_MDSS_HW_VERSION` instead of `ubwc_dec_version`. The renaming from `msm_mdss_setup_ubwc_dec_XX` to `msm_mdss_Nx_setup_ubwc` makes the intent clear. The `MDSS_HW_VER` macro is well-defined. The swizzle masking with `& 0x1` in `msm_mdss_4x_setup_ubwc` correctly limits to level 1 for MDSS 4.x hardware. The bank_spread removal from the 4x path is correct since MDSS 4.x doesn't have that register bit. **Note:** The old code had explicit error handling for unknown UBWC decoder versions (`default:` case with `dev_err`). The new code silently does nothing for MDSS < 4.0 with the comment `/* else UBWC 1.0 or none, no params to program */`. This loses diagnostics for truly unknown hardware, which is a minor tradeoff. No bugs. Looks correct. --- Generated by Claude Code Patch Reviewer