public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: bridge: ti, sn65dsi83: Add dual-link video mode property
Date: Fri, 13 Mar 2026 14:32:11 +1000	[thread overview]
Message-ID: <review-patch1-20260312043743.261475-2-tessolveupstream@gmail.com> (raw)
In-Reply-To: <20260312043743.261475-2-tessolveupstream@gmail.com>

Patch Review

**Questionable need for the property.** The driver already determines dual-link mode from the OF graph port topology (`ctx->lvds_dual_link`). A separate boolean `ti,dual-link-video-mode` is redundant — if dual-link is already detected, the driver should automatically apply the correct register programming. If the intent is to distinguish between different dual-link sub-modes, the property name and description don't make that clear.

**DT binding description is vague:**
```yaml
+  ti,dual-link-video-mode:
+    type: boolean
+    description: |
+      Enables configuration settings required for correct dual-link
+      LVDS operation. Some panels require the horizontal timing
+      parameters to be adjusted before being programmed into the
+      device. The horizontal timing values must be divided by
+      two when operating in dual-link mode.
```
The description says "some panels require" this — but a boolean property doesn't encode which panels or under what conditions. If all dual-link panels need this, it should be automatic. If only some do, the binding needs to explain what distinguishes those panels.

**No `allOf`/`if-then` constraint.** The property should only be valid for `ti,sn65dsi84` (and possibly `ti,sn65dsi85`), not `ti,sn65dsi83` which only supports single-link. The binding should add a conditional to restrict where this property is allowed.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-13  4:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12  4:37 [PATCH v2 0/2] drm: bridge: ti-sn65dsi83: Improve dual-link LVDS support Sudarshan Shetty
2026-03-12  4:37 ` [PATCH v2 1/2] dt-bindings: display: bridge: ti, sn65dsi83: Add dual-link video mode property Sudarshan Shetty
2026-03-12 15:46   ` Luca Ceresoli
2026-03-13  4:32   ` Claude Code Review Bot [this message]
2026-03-12  4:37 ` [PATCH v2 2/2] drm: bridge: ti-sn65dsi83: Add support for dual-link LVDS video mode Sudarshan Shetty
2026-03-12 15:47   ` Luca Ceresoli
2026-03-13  4:32   ` Claude review: " Claude Code Review Bot
2026-03-12  5:05 ` [PATCH v2 0/2] drm: bridge: ti-sn65dsi83: Improve dual-link LVDS support Marek Vasut
2026-03-12 12:35   ` tessolveupstream
2026-03-12 15:49     ` Luca Ceresoli
2026-03-13  4:32 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260312043743.261475-2-tessolveupstream@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox