public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/display: Add drm helper to check pr optimization support
Date: Fri, 13 Mar 2026 14:30:26 +1000	[thread overview]
Message-ID: <review-patch1-20260312050035.3493690-2-animesh.manna@intel.com> (raw)
In-Reply-To: <20260312050035.3493690-2-animesh.manna@intel.com>

Patch Review

**Documentation typo:**
```
 * Returns %true if the PR BW optimiation is supported for @tunnel.
```
"optimiation" → "optimization"

**Redundancy with existing tree code:** The drm-next tree already reads `DP_PANEL_REPLAY_OPTIMIZATION_SUPPORT` from `DP_TUNNELING_CAPABILITIES` in the `drm_dp_tunnel_detect()` debug print (line ~793 of `drm_dp_tunnel.c`), but doesn't store it. This patch correctly adds the `pr_optimization_support` bitfield and caches the value at tunnel creation time in `create_tunnel()`. However, note that `create_tunnel()` is called from `drm_dp_tunnel_detect()`, and the capability is already read from the same `regs` struct there. The approach is consistent with how `bw_alloc_supported` is handled — good.

**Missing update in `update_tunnel_regs()`:** The existing code checks whether `bw_alloc_supported` has changed across hotplug/resume in `update_tunnel_regs()` (around line 628). The new `pr_optimization_support` field is only set in `create_tunnel()` but is never updated or checked for changes in `update_tunnel_regs()`. If the tunnel bridge firmware were updated or the bridge changed, the cached value could become stale. Consider whether this needs a similar change-detection path. This is a minor concern since capability changes between detect calls are unlikely, but it's an inconsistency with the `bw_alloc_supported` pattern.

**No `EXPORT_SYMBOL_GPL`:** The existing exports in `drm_dp_tunnel.c` use `EXPORT_SYMBOL`. This patch follows the same convention, which is consistent. Just noting this is fine.

Overall this patch is clean and straightforward.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-13  4:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12  5:00 [PATCH v7 0/3] Panel Replay BW optimization Animesh Manna
2026-03-12  5:00 ` [PATCH v7 1/3] drm/i915/display: Add drm helper to check pr optimization support Animesh Manna
2026-03-12  6:40   ` Hogander, Jouni
2026-03-12  8:36     ` Manna, Animesh
2026-03-13  4:30   ` Claude Code Review Bot [this message]
2026-03-12  5:00 ` [PATCH v7 2/3] drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling Animesh Manna
2026-03-12  6:44   ` Hogander, Jouni
2026-03-12  8:44     ` Manna, Animesh
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot
2026-03-12  5:00 ` [PATCH v7 3/3] drm/i915/display: Disable Panel Replay for DP-tunneling without optimization Animesh Manna
2026-03-12  6:17   ` Hogander, Jouni
2026-03-12  8:33     ` Manna, Animesh
2026-03-13  4:30   ` Claude review: " Claude Code Review Bot
2026-03-12  8:05 ` [PATCH v7 0/3] Panel Replay BW optimization Hogander, Jouni
2026-03-12  8:41   ` Manna, Animesh
2026-03-12 15:18   ` Imre Deak
2026-03-13  4:30 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260312050035.3493690-2-animesh.manna@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox