From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Add drm helper to check pr optimization support Date: Fri, 13 Mar 2026 14:30:26 +1000 Message-ID: In-Reply-To: <20260312050035.3493690-2-animesh.manna@intel.com> References: <20260312050035.3493690-1-animesh.manna@intel.com> <20260312050035.3493690-2-animesh.manna@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Documentation typo:** ``` * Returns %true if the PR BW optimiation is supported for @tunnel. ``` "optimiation" =E2=86=92 "optimization" **Redundancy with existing tree code:** The drm-next tree already reads `DP= _PANEL_REPLAY_OPTIMIZATION_SUPPORT` from `DP_TUNNELING_CAPABILITIES` in the= `drm_dp_tunnel_detect()` debug print (line ~793 of `drm_dp_tunnel.c`), but= doesn't store it. This patch correctly adds the `pr_optimization_support` = bitfield and caches the value at tunnel creation time in `create_tunnel()`.= However, note that `create_tunnel()` is called from `drm_dp_tunnel_detect(= )`, and the capability is already read from the same `regs` struct there. T= he approach is consistent with how `bw_alloc_supported` is handled =E2=80= =94 good. **Missing update in `update_tunnel_regs()`:** The existing code checks whet= her `bw_alloc_supported` has changed across hotplug/resume in `update_tunne= l_regs()` (around line 628). The new `pr_optimization_support` field is onl= y set in `create_tunnel()` but is never updated or checked for changes in `= update_tunnel_regs()`. If the tunnel bridge firmware were updated or the br= idge changed, the cached value could become stale. Consider whether this ne= eds a similar change-detection path. This is a minor concern since capabili= ty changes between detect calls are unlikely, but it's an inconsistency wit= h the `bw_alloc_supported` pattern. **No `EXPORT_SYMBOL_GPL`:** The existing exports in `drm_dp_tunnel.c` use `= EXPORT_SYMBOL`. This patch follows the same convention, which is consistent= . Just noting this is fine. Overall this patch is clean and straightforward. --- Generated by Claude Code Patch Reviewer