From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/hisilicon/hibmc: add updating link cap in DP detect() Date: Fri, 13 Mar 2026 14:23:18 +1000 Message-ID: In-Reply-To: <20260312074202.1491504-2-shiyongbang@huawei.com> References: <20260312074202.1491504-1-shiyongbang@huawei.com> <20260312074202.1491504-2-shiyongbang@huawei.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Commit message issue:** The commit message says "So add the hibmc_dp_upda= te_caps() in hibmc_dp_update_caps()" which is a copy-paste error =E2=80=94 = it should say something like "add hibmc_dp_update_caps() in hibmc_dp_get_dp= cd()". The code change itself is straightforward and correct =E2=80=94 `hibmc_dp_u= pdate_caps()` was `static` and is now exported, and it's called in `hibmc_d= p_get_dpcd()` after reading DPCD caps, which runs during `detect()`. This e= nsures `link.cap.link_rate` and `link.cap.lanes` are populated before `hibm= c_dp_mode_valid()` uses them. No functional concerns with the code. --- Generated by Claude Code Patch Reviewer