From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH 01/15] tracepoint: Add trace_invoke_##name() API
Date: Fri, 13 Mar 2026 14:04:52 +1000
Message-ID: <review-patch1-20260312111255.7925b4e2@gandalf.local.home>
In-Reply-To: <20260312111255.7925b4e2@gandalf.local.home>
References: <1e3c2830-765e-4271-89f7-0b6784b37597@efficios.com> <20260312111255.7925b4e2@gandalf.local.home>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

The core API patch. Three changes to `include/linux/tracepoint.h`:

1. **`__DECLARE_TRACE`** =E2=80=94 adds `trace_invoke_##name()` after `trac=
e_##name()`:
```c
static inline void trace_invoke_##name(proto)
{
    __do_trace_##name(args);
}
```
This correctly skips the `static_branch_unlikely()` but as noted above, it =
also **omits the LOCKDEP assertion**. The commit message claims it "retains=
 the LOCKDEP RCU-watching assertion" which is inaccurate.

2. **`__DECLARE_TRACE_SYSCALL`** =E2=80=94 same pattern but includes `might=
_fault()`:
```c
static inline void trace_invoke_##name(proto)
{
    might_fault();
    __do_trace_##name(args);
}
```
This correctly preserves the `might_fault()` check. Same LOCKDEP concern ap=
plies here too.

3. **`!TRACEPOINTS_ENABLED` stub** =E2=80=94 adds an empty inline:
```c
static inline void trace_invoke_##name(proto)
{ }
```
Correct =E2=80=94 compiles out cleanly when tracepoints are disabled.

**Minor nit**: The `trace_invoke_` naming prefix is somewhat verbose. An al=
ternative like `trace_do_` was presumably considered and rejected, but the =
chosen name is fine =E2=80=94 it's explicit about what it does.

---
Generated by Claude Code Patch Reviewer