From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: ite-it66121: Disable HDMI audio capture stream Date: Fri, 13 Mar 2026 13:51:27 +1000 Message-ID: In-Reply-To: <20260312193355.1348842-1-sen@ti.com> References: <20260312193355.1348842-1-sen@ti.com> <20260312193355.1348842-1-sen@ti.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The patch correctly sets both `no_i2s_capture` and `no_spd= if_capture` to `1` in the `hdmi_codec_pdata` initializer at `ite-it66121.c:= 1475-1476`. Both fields are valid members of `struct hdmi_codec_pdata` (def= ined in `include/sound/hdmi-codec.h:126,129`). Since the driver already set= s `.spdif =3D 0` (SPDIF disabled entirely) and `.i2s =3D 1`, adding `.no_i2= s_capture =3D 1` is the important one here, while `.no_spdif_capture =3D 1`= is a belt-and-suspenders addition that doesn't hurt. **Placement:** The new fields are placed logically between `.max_i2s_channe= ls` and `.no_capture_mute`, matching the struct field order in the header, = which is good style. **Precedent:** The `tda998x` bridge driver (`drivers/gpu/drm/bridge/tda998x= _drv.c:1177`) already uses `.no_i2s_capture =3D 1` in the same manner, conf= irming this is the established pattern. **Commit message:** Clear and well-written =E2=80=94 explains the hardware = limitation, the symptom (PulseAudio errors), and the fix. **Minor observation:** Since `.spdif =3D 0` already means SPDIF is disabled= , setting `.no_spdif_capture =3D 1` is technically redundant but harmless a= nd defensive. This is fine. **No issues found.**=20 Reviewed-by quality: this patch is ready to merge as-is. --- Generated by Claude Code Patch Reviewer