public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Align style of "true" properties
Date: Sat, 14 Mar 2026 07:18:06 +1000	[thread overview]
Message-ID: <review-patch1-20260313-dt-bindings-display-panel-clean-v2-1-d49615218f92@oss.qualcomm.com> (raw)
In-Reply-To: <20260313-dt-bindings-display-panel-clean-v2-1-d49615218f92@oss.qualcomm.com>

Patch Review

**Changes across 11 YAML binding files:**

The patch consistently applies two style rules:

1. **Remove blank lines between consecutive `": true"` properties** — e.g., in `himax,hx8394.yaml`:
   ```yaml
   -  reset-gpios: true
   -
   -  backlight: true
   -
   -  rotation: true
   -
   -  port: true
   +  reset-gpios: true
   +  backlight: true
   +  rotation: true
   +  port: true
   ```

2. **Add a blank line between the `": true"` block and properties with sub-fields** — e.g., in `leadtek,ltk050h3146w.yaml`:
   ```yaml
      reset-gpios: true
   +
      iovcc-supply:
        description: regulator that supplies the iovcc voltage
   ```

3. **Reorder some `": true"` properties to group them together at the end of the properties block** — e.g., in `mantix,mlaf057we51-x.yaml`, `port: true` and `reset-gpios: true` are moved from their scattered locations to a grouped block alongside `backlight: true`. Similarly in `rocktech,jh057n00900.yaml`, `novatek,nt35510.yaml`, and `startek,kd070fhfid015.yaml`.

**Assessment:** All changes are consistent and correctly applied. The reordering of properties within the `properties:` block in YAML schemas has no functional impact since property order does not affect DT binding validation. The patch improves readability by making the style uniform across these files.

No issues found. This is a clean cosmetic patch ready to be applied.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-13 21:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  8:20 [PATCH v2] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
2026-03-13 21:18 ` Claude review: " Claude Code Review Bot
2026-03-13 21:18 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
2026-03-08 22:53   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260313-dt-bindings-display-panel-clean-v2-1-d49615218f92@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox