public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge
Date: Sat, 14 Mar 2026 07:27:22 +1000	[thread overview]
Message-ID: <review-patch1-20260313-upstream-6162-v3-1-8497fb7c4406@ite.com.tw> (raw)
In-Reply-To: <20260313-upstream-6162-v3-1-8497fb7c4406@ite.com.tw>

Patch Review

The binding looks generally well-structured. A few observations:

1. **`ports` required only lists `port@1`** (line 2078-2079): The binding requires only `port@1` (DSI-1) but not `port@0` (DSI-0). This seems backwards — for single-link operation you'd expect `port@0` to be the required one, with `port@1` being optional for dual-link. At minimum, shouldn't `port@0` be required, or should it be an `anyOf` / `oneOf` requiring at least one DSI port?

2. **Missing required supplies**: The `reset-gpios`, `ivdd-supply`, `ovdd-supply`, and `ovdd1833-supply` are not listed in `required:` (lines 2080-2085), but the driver unconditionally calls `devm_regulator_get` and `devm_gpiod_get` for them (not `_optional` variants). Either these should be `required` in the binding, or the driver should use the optional getters.

3. **`#sound-dai-cells` in example but not required**: The example shows `#sound-dai-cells = <0>` but there's no constraint tying it to the audio port presence. This is minor but could benefit from a conditional `required` or `if/then`.

4. **`ite,support-hdcp` typo in v2 changelog**: The changelog mentions `"ite,spport-hdcp"` — just a cosmetic note; the actual binding correctly uses `ite,support-hdcp`.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13 21:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  6:15 [PATCH v3 0/2] Add ITE IT6162 MIPI DSI to HDMI bridge driver Hermes Wu via B4 Relay
2026-03-13  6:16 ` [PATCH v3 1/2] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Hermes Wu via B4 Relay
2026-03-13 21:27   ` Claude Code Review Bot [this message]
2026-03-13  6:16 ` [PATCH v3 2/2] drm/bridge: Add ITE IT6162 MIPI DSI to HDMI bridge driver Hermes Wu via B4 Relay
2026-03-13 21:27   ` Claude review: " Claude Code Review Bot
2026-03-13 21:27 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-19  6:37 [PATCH v4 0/2] " Hermes Wu via B4 Relay
2026-03-19  6:37 ` [PATCH v4 1/2] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Hermes Wu via B4 Relay
2026-03-21 18:39   ` Claude review: " Claude Code Review Bot
2026-03-09  9:42 [PATCH v2 0/2] Add ITE IT6162 MIPI DSI to HDMI bridge driver Hermes Wu via B4 Relay
2026-03-09  9:42 ` [PATCH v2 1/2] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Hermes Wu via B4 Relay
2026-03-10  2:31   ` Claude review: " Claude Code Review Bot
2026-02-23  9:20 [PATCH 0/3] Add ITE IT6162 MIPI DSI to HDMI bridge driver Hermes Wu via B4 Relay
2026-02-23  9:20 ` [PATCH 2/3] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Hermes Wu via B4 Relay
2026-02-24  0:21   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260313-upstream-6162-v3-1-8497fb7c4406@ite.com.tw \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox