From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Date: Sat, 14 Mar 2026 07:27:22 +1000 Message-ID: In-Reply-To: <20260313-upstream-6162-v3-1-8497fb7c4406@ite.com.tw> References: <20260313-upstream-6162-v3-0-8497fb7c4406@ite.com.tw> <20260313-upstream-6162-v3-1-8497fb7c4406@ite.com.tw> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The binding looks generally well-structured. A few observations: 1. **`ports` required only lists `port@1`** (line 2078-2079): The binding r= equires only `port@1` (DSI-1) but not `port@0` (DSI-0). This seems backward= s =E2=80=94 for single-link operation you'd expect `port@0` to be the requi= red one, with `port@1` being optional for dual-link. At minimum, shouldn't = `port@0` be required, or should it be an `anyOf` / `oneOf` requiring at lea= st one DSI port? 2. **Missing required supplies**: The `reset-gpios`, `ivdd-supply`, `ovdd-s= upply`, and `ovdd1833-supply` are not listed in `required:` (lines 2080-208= 5), but the driver unconditionally calls `devm_regulator_get` and `devm_gpi= od_get` for them (not `_optional` variants). Either these should be `requir= ed` in the binding, or the driver should use the optional getters. 3. **`#sound-dai-cells` in example but not required**: The example shows `#= sound-dai-cells =3D <0>` but there's no constraint tying it to the audio po= rt presence. This is minor but could benefit from a conditional `required` = or `if/then`. 4. **`ite,support-hdcp` typo in v2 changelog**: The changelog mentions `"it= e,spport-hdcp"` =E2=80=94 just a cosmetic note; the actual binding correctl= y uses `ite,support-hdcp`. --- Generated by Claude Code Patch Reviewer