From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tyr: clear reset IRQ before soft reset
Date: Sat, 14 Mar 2026 07:15:46 +1000 [thread overview]
Message-ID: <review-patch1-20260313091646.16938-2-work@onurozkan.dev> (raw)
In-Reply-To: <20260313091646.16938-2-work@onurozkan.dev>
Patch Review
**Verdict: Looks good.**
This is a straightforward and correct fix. Clearing `RESET_COMPLETED` from `GPU_IRQ_CLEAR` before issuing `GPU_CMD_SOFT_RESET` prevents the subsequent `poll::read_poll_timeout` from seeing stale status from a previous reset cycle.
```rust
+ // Clear any stale reset-complete IRQ state before issuing a new soft reset.
+ regs::GPU_IRQ_CLEAR.write(dev, iomem, regs::GPU_IRQ_RAWSTAT_RESET_COMPLETED)?;
regs::GPU_CMD.write(dev, iomem, regs::GPU_CMD_SOFT_RESET)?;
```
This matches the pattern used by `panfrost_gpu_soft_reset()` as the commit message states. No issues.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 21:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 9:16 [PATCH v1 RESEND 0/4] drm/tyr: implement GPU reset API Onur Özkan
2026-03-13 9:16 ` [PATCH v1 RESEND 1/4] drm/tyr: clear reset IRQ before soft reset Onur Özkan
2026-03-13 21:15 ` Claude Code Review Bot [this message]
2026-03-13 9:16 ` [PATCH v1 RESEND 2/4] rust: add Work::disable_sync Onur Özkan
2026-03-13 12:00 ` Alice Ryhl
2026-03-13 21:15 ` Claude review: " Claude Code Review Bot
2026-03-13 9:16 ` [PATCH v1 RESEND 3/4] rust: add ordered workqueue wrapper Onur Özkan
2026-03-13 21:15 ` Claude review: " Claude Code Review Bot
2026-03-13 9:16 ` [PATCH v1 RESEND 4/4] drm/tyr: add GPU reset handling Onur Özkan
2026-03-13 14:56 ` Daniel Almeida
2026-03-13 21:15 ` Claude review: " Claude Code Review Bot
2026-03-13 9:52 ` [PATCH v1 RESEND 0/4] drm/tyr: implement GPU reset API Alice Ryhl
2026-03-13 11:12 ` Onur Özkan
2026-03-13 11:26 ` Alice Ryhl
2026-03-13 21:15 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260313091646.16938-2-work@onurozkan.dev \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox