public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: [linux-next mismerge] drm/fbdev-emulation: restore drm_fb_helper_gem_is_fb() dummy
Date: Sat, 14 Mar 2026 07:12:57 +1000	[thread overview]
Message-ID: <review-patch1-20260313095657.4115599-1-arnd@kernel.org> (raw)
In-Reply-To: <20260313095657.4115599-1-arnd@kernel.org>

Patch Review

**Correctness: Good.** The patch adds an `#else` static inline stub that returns `false` for `drm_fb_helper_gem_is_fb()`. This is the correct semantic — when fbdev emulation is disabled, there is no fbdev framebuffer, so "is this GEM object the fbdev FB?" should always return `false`.

```c
+static inline bool
+drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,
+			const struct drm_gem_object *obj)
+{
+	return false;
+}
```

The function signature matches the declaration shown in the diff context (lines 98-99):
```c
 bool drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,
 			     const struct drm_gem_object *obj);
```

**One observation:** Looking at the current drm-next tree (`drm_fb_helper.h:274`), the `#ifdef CONFIG_DRM_FBDEV_EMULATION` block currently has no `#else` at all — it just ends with `#endif`. The patch's context lines show `drm_fb_helper_gem_is_fb` declared at lines 98-99 before the `#else`, which means this patch is based on the linux-next merged state where the amdgpu tree's additions are already present. This is expected for a linux-next fixup and wouldn't apply to drm-next alone.

**Commit message: Well written.** It clearly explains the conflicting commits, includes the compiler error messages, references all three relevant Fixes: tags, and identifies precisely which stub needs restoration.

**No issues found.** The patch is a correct and minimal fix for the linux-next build breakage.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13 21:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  9:56 [PATCH] [linux-next mismerge] drm/fbdev-emulation: restore drm_fb_helper_gem_is_fb() dummy Arnd Bergmann
2026-03-13 21:12 ` Claude Code Review Bot [this message]
2026-03-13 21:12 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260313095657.4115599-1-arnd@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox