From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: [linux-next mismerge] drm/fbdev-emulation: restore drm_fb_helper_gem_is_fb() dummy
Date: Sat, 14 Mar 2026 07:12:57 +1000
Message-ID: <review-patch1-20260313095657.4115599-1-arnd@kernel.org>
In-Reply-To: <20260313095657.4115599-1-arnd@kernel.org>
References: <20260313095657.4115599-1-arnd@kernel.org> <20260313095657.4115599-1-arnd@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Correctness: Good.** The patch adds an `#else` static inline stub that re=
turns `false` for `drm_fb_helper_gem_is_fb()`. This is the correct semantic=
 =E2=80=94 when fbdev emulation is disabled, there is no fbdev framebuffer,=
 so "is this GEM object the fbdev FB?" should always return `false`.

```c
+static inline bool
+drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,
+			const struct drm_gem_object *obj)
+{
+	return false;
+}
```

The function signature matches the declaration shown in the diff context (l=
ines 98-99):
```c
 bool drm_fb_helper_gem_is_fb(const struct drm_fb_helper *fb_helper,
 			     const struct drm_gem_object *obj);
```

**One observation:** Looking at the current drm-next tree (`drm_fb_helper.h=
:274`), the `#ifdef CONFIG_DRM_FBDEV_EMULATION` block currently has no `#el=
se` at all =E2=80=94 it just ends with `#endif`. The patch's context lines =
show `drm_fb_helper_gem_is_fb` declared at lines 98-99 before the `#else`, =
which means this patch is based on the linux-next merged state where the am=
dgpu tree's additions are already present. This is expected for a linux-nex=
t fixup and wouldn't apply to drm-next alone.

**Commit message: Well written.** It clearly explains the conflicting commi=
ts, includes the compiler error messages, references all three relevant Fix=
es: tags, and identifies precisely which stub needs restoration.

**No issues found.** The patch is a correct and minimal fix for the linux-n=
ext build breakage.

---
Generated by Claude Code Patch Reviewer