From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur ADSP Date: Sat, 14 Mar 2026 07:07:32 +1000 Message-ID: In-Reply-To: <20260313120814.1312410-2-sibi.sankar@oss.qualcomm.com> References: <20260313120814.1312410-1-sibi.sankar@oss.qualcomm.com> <20260313120814.1312410-2-sibi.sankar@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `qcom,glymur-adsp-pas` to the sm8550-pas binding with fallback to `qcom,sm8550-adsp-pas`. The compatible is added in two places: 1. The compatible property items group (alongside kaanapali and sm8750): ```yaml - qcom,glymur-adsp-pas - qcom,kaanapali-adsp-pas - qcom,sm8750-adsp-pas - const: qcom,sm8550-adsp-pas ``` 2. The allOf conditional that allows 6 interrupts (the extra "shutdown-ack"): ```yaml - qcom,glymur-adsp-pas - qcom,kaanapali-adsp-pas ``` Both additions are correctly placed. The commit message accurately describes the compatibility: Glymur ADSP shares the same fallback chain as SM8750 ADSP (both fall back to SM8550-adsp-pas), differing from the base SM8550 only in the additional "shutdown-ack" interrupt. No issues. --- Generated by Claude Code Patch Reviewer