public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/dp: Add quirk to disable Panel Replay on certain panels
Date: Sat, 14 Mar 2026 07:04:35 +1000	[thread overview]
Message-ID: <review-patch1-20260313122145.1747175-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20260313122145.1747175-2-jouni.hogander@intel.com>

Patch Review

**Quirk scope is overly broad (major concern):**

The quirk entry uses `DEVICE_ID_ANY`:
```c
{ OUI(0x00, 0x22, 0xb9), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_NO_PANEL_REPLAY) },
```

OUI `0x00, 0x22, 0xb9` is the LG Display OUI. Using `DEVICE_ID_ANY` means this quirk will match **all** LG Display sink devices (non-branch, `is_branch=false`), not just the specific problematic panel model. The cover letter says "LGD panel" (singular), and the commit message says "LG panel" — this suggests a specific panel model is affected, but the quirk disables Panel Replay for every LG eDP/DP sink panel.

Compare with the existing `DP_DPCD_QUIRK_NO_PSR` for Apple panels — that was also `DEVICE_ID_ANY`, but that was a broader decision about all Apple panels. Here, the commit message says "problems with LG panel" implying a specific model. If the specific device ID is known (as it was for the `LP140WF6-SPM1` entry on line 2542), it should be used to avoid unnecessarily disabling Panel Replay on other LG panels that work fine.

The comment is also vague:
```c
/* Problems observed with LG panel */
```
It would be better to include the specific panel model or reference the bug tracker issue (which is in patch 2's commit message but not here).

**Enum placement is correct:** `DP_DPCD_QUIRK_NO_PANEL_REPLAY` is placed right after `DP_DPCD_QUIRK_NO_PSR`, which is logically sensible since they are related features.

**Documentation comment has minor grammar issue:**
```c
 * The device does not support Panel Replay even if reports
 * that it supports or driver still need to implement proper
 * handling for such device.
```
"even if reports" should be "even if it reports", and "driver still need" should be "the driver still needs". This is the same wording as `DP_DPCD_QUIRK_NO_PSR` though, so that's a pre-existing issue being copied.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 12:21 [PATCH 0/2] Disable Panel Replay as quirk for LGD panel Jouni Högander
2026-03-13 12:21 ` [PATCH 1/2] drm/dp: Add quirk to disable Panel Replay on certain panels Jouni Högander
2026-03-13 21:04   ` Claude Code Review Bot [this message]
2026-03-13 12:21 ` [PATCH 2/2] drm/i915/psr: Disable Panel Replay on DP_DPCD_QUIRK_NO_PANEL_REPLAY quirk Jouni Högander
2026-03-13 21:04   ` Claude review: " Claude Code Review Bot
2026-03-13 21:04 ` Claude review: Disable Panel Replay as quirk for LGD panel Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260313122145.1747175-2-jouni.hogander@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox