From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/dp: Add quirk to disable Panel Replay on certain panels Date: Sat, 14 Mar 2026 07:04:35 +1000 Message-ID: In-Reply-To: <20260313122145.1747175-2-jouni.hogander@intel.com> References: <20260313122145.1747175-1-jouni.hogander@intel.com> <20260313122145.1747175-2-jouni.hogander@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Quirk scope is overly broad (major concern):** The quirk entry uses `DEVICE_ID_ANY`: ```c { OUI(0x00, 0x22, 0xb9), DEVICE_ID_ANY, false, BIT(DP_DPCD_QUIRK_NO_PANEL_R= EPLAY) }, ``` OUI `0x00, 0x22, 0xb9` is the LG Display OUI. Using `DEVICE_ID_ANY` means t= his quirk will match **all** LG Display sink devices (non-branch, `is_branc= h=3Dfalse`), not just the specific problematic panel model. The cover lette= r says "LGD panel" (singular), and the commit message says "LG panel" =E2= =80=94 this suggests a specific panel model is affected, but the quirk disa= bles Panel Replay for every LG eDP/DP sink panel. Compare with the existing `DP_DPCD_QUIRK_NO_PSR` for Apple panels =E2=80=94= that was also `DEVICE_ID_ANY`, but that was a broader decision about all A= pple panels. Here, the commit message says "problems with LG panel" implyin= g a specific model. If the specific device ID is known (as it was for the `= LP140WF6-SPM1` entry on line 2542), it should be used to avoid unnecessaril= y disabling Panel Replay on other LG panels that work fine. The comment is also vague: ```c /* Problems observed with LG panel */ ``` It would be better to include the specific panel model or reference the bug= tracker issue (which is in patch 2's commit message but not here). **Enum placement is correct:** `DP_DPCD_QUIRK_NO_PANEL_REPLAY` is placed ri= ght after `DP_DPCD_QUIRK_NO_PSR`, which is logically sensible since they ar= e related features. **Documentation comment has minor grammar issue:** ```c * The device does not support Panel Replay even if reports * that it supports or driver still need to implement proper * handling for such device. ``` "even if reports" should be "even if it reports", and "driver still need" s= hould be "the driver still needs". This is the same wording as `DP_DPCD_QUI= RK_NO_PSR` though, so that's a pre-existing issue being copied. --- Generated by Claude Code Patch Reviewer