public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Fix GMEM_BASE for A650
Date: Mon, 16 Mar 2026 12:09:20 +1000	[thread overview]
Message-ID: <review-patch1-20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me> (raw)
In-Reply-To: <20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me>

Patch Review

**Correctness: Good.** The enum in `adreno_gpu.h:47-50` shows:
```
ADRENO_6XX_GEN1,  /* a630 family */
ADRENO_6XX_GEN2,  /* a640 family */
ADRENO_6XX_GEN3,  /* a650 family */
ADRENO_6XX_GEN4,  /* a660 family */
```

The `adreno_is_a650_family()` helper at `adreno_gpu.h:540-541` explicitly includes both GEN3 and GEN4:
```c
return gpu->info->family == ADRENO_6XX_GEN3 ||
       gpu->info->family == ADRENO_6XX_GEN4;
```

So the original intent was to return `GMEM_BASE = 0` for a650 family and above. The regressing commit changed the `>=` threshold to `ADRENO_6XX_GEN4`, excluding GEN3 (a650). Changing it to `>= ADRENO_6XX_GEN3` restores the correct behavior and is also a cleaner expression than the original pair of `adreno_is_a650_family() || adreno_is_a740_family()` checks, since all families from GEN3 onward should use GMEM_BASE of 0.

**Commit message:** Clear and well-written. Correctly identifies the regressing commit, the root cause, and the symptom (rendering corruption). Has the appropriate `Fixes:` tag.

**No issues found.** This is a clean, minimal one-line regression fix.

Reviewed-by worthy. No changes requested.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-16  2:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14  4:14 [PATCH] drm/msm: Fix GMEM_BASE for A650 Alexander Koskovich
2026-03-16  2:09 ` Claude review: " Claude Code Review Bot
2026-03-16  2:09 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox