From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v4 1/3] dt-bindings: display: panel: Add Samsung S6E8FCO-M1906F9 Date: Mon, 16 Mar 2026 11:54:45 +1000 Message-ID: In-Reply-To: <20260315-misty-organic-dingo-50bfc9@quoll> References: <20260314-panel-patches-v4-0-1ecbb2c0c3c8@gmail.com> <20260315-misty-organic-dingo-50bfc9@quoll> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch extends the existing `samsung,s6e8aa5x01-ams561ra01.yaml` bindin= g to add a new compatible `samsung,s6e8fco-m1906f9`. **Concern: Are these panels similar enough to share a binding?** The S6E8AA= 5X01 and S6E8FCO are different DSI controllers. Sharing a binding YAML impl= ies they have the same DT interface (same supplies, same properties). Looki= ng at the existing binding, it requires `vdd-supply`, `vci-supply`, `reset-= gpios`, which matches what the new driver uses =E2=80=94 so the DT interfac= e is compatible. However, the binding title says "Samsung AMS561RA01 panel = with S6E8AA5X01 controller" which is now inaccurate for the new compatible.= This was likely suggested during review to avoid a separate near-identical= binding file, which is fine. **Minor:** Adding yourself as a maintainer of this binding file is fine sin= ce you're adding a compatible, but the MAINTAINERS entry in patch 2 doesn't= list this binding file =E2=80=94 consider adding `F: Documentation/devicet= ree/bindings/display/panel/samsung,s6e8aa5x01-ams561ra01.yaml` to the MAINT= AINERS block. Otherwise looks fine. --- --- Generated by Claude Code Patch Reviewer