public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Add Himax HX83121A
Date: Mon, 16 Mar 2026 11:51:07 +1000	[thread overview]
Message-ID: <review-patch1-20260315144536.515032-2-mitltlatltl@gmail.com> (raw)
In-Reply-To: <20260315144536.515032-2-mitltlatltl@gmail.com>

Patch Review

**Missing dual-DSI port schema.** This is a dual-DSI panel (as the example and driver show), yet the binding doesn't reference `panel-common-dual.yaml` or define a `ports` schema at all. Compare with `novatek,nt36523.yaml` which uses:
```yaml
allOf:
  - $ref: panel-common-dual.yaml#
```
Without this, `dt_binding_check` likely won't validate the `ports` node in the example, and the `port@1` in the example is undocumented. The `additionalProperties: false` should probably become `unevaluatedProperties: false` when using the `$ref`.

**Missing `port` property.** The example has a `ports` node with two ports, but there is no `port` or `ports` property declared in the schema. This is handled by the `panel-common-dual.yaml` ref, but since it's not referenced, this is an omission.

**`avdd-supply` and `avee-supply` not required.** They are listed as optional in the binding but the driver always requests them via `regulator_bulk_get`. If the hardware always needs them, consider making them required, or at minimum document that they are optional (which they currently are, as regulators can be dummy). This is minor - the current approach is acceptable if dummy regulators suffice.

**Minor style in example:** `port@1{` is missing a space before `{` (line 326 of the binding yaml). Should be `port@1 {`. This exists in the nt36523 binding too, but it's still poor style.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-16  1:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-15 14:45 [PATCH v2 0/2] drm/panel: Add Himax HX83121A panel driver Pengyu Luo
2026-03-15 14:45 ` [PATCH v3 1/2] dt-bindings: display: panel: Add Himax HX83121A Pengyu Luo
2026-03-15 16:19   ` Rob Herring (Arm)
2026-03-16  1:51   ` Claude Code Review Bot [this message]
2026-03-15 14:45 ` [PATCH v3 2/2] drm/panel: Add Himax HX83121A panel driver Pengyu Luo
2026-03-16  1:51   ` Claude review: " Claude Code Review Bot
2026-03-16  1:51 ` Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-03 11:57 [PATCH 0/2] " Pengyu Luo
2026-03-03 11:57 ` [PATCH 1/2] dt-bindings: display: panel: Add Himax HX83121A Pengyu Luo
2026-03-03 21:28   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260315144536.515032-2-mitltlatltl@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox