public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: add edid_overridden flag to drm_connector
Date: Mon, 16 Mar 2026 11:48:51 +1000	[thread overview]
Message-ID: <review-patch1-20260315223307.45807-2-johanneswueller@gmail.com> (raw)
In-Reply-To: <20260315223307.45807-2-johanneswueller@gmail.com>

Patch Review

**Approach concern:** The flag is set only inside `_drm_do_get_edid()`, which is the legacy EDID read path. While `drm_edid_read_ddc()` currently chains through `_drm_do_get_edid()`, this is an implementation detail that could change. A more robust approach would be to check at query time whether an override exists (e.g. via `drm_edid_override_get()` or checking `connector->edid_override`), rather than caching a flag that can become stale.

**Staleness risk:** The flag is set during EDID read, but nothing clears it if the override is removed between reads. If userspace removes an override via debugfs without triggering a new EDID read, `edid_overridden` remains `true`. The `connector->edid_overridden = false` at line 2376 only runs when `_drm_do_get_edid()` is called again.

**Missing Cc:** The patch modifies core DRM infrastructure but doesn't Cc `linux-kernel@vger.kernel.org` in the commit (though it is in the email headers from get_maintainer). More importantly, it would benefit from Cc'ing the DRM misc maintainers explicitly since this touches `drm_connector.h`.

**Naming:** `edid_overridden` is reasonable, but `edid_override_active` might be clearer since it describes current state rather than a past-tense event.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-16  1:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-15 22:33 [PATCH 0/4] drm/amd: fix HDMI output with non-HDMI EDID overrides Johannes Wüller
2026-03-15 22:33 ` [PATCH 1/4] drm: add edid_overridden flag to drm_connector Johannes Wüller
2026-03-16  1:48   ` Claude Code Review Bot [this message]
2026-03-15 22:33 ` [PATCH 2/4] drm/amd: fix HDMI signal type for EDID overrides Johannes Wüller
2026-03-16  1:48   ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 3/4] drm/amd: treat max_tmds_clock==0 as unconstrained Johannes Wüller
2026-03-16  1:48   ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 4/4] drm/amd: fix force_yuv420/422_output being ignored Johannes Wüller
2026-03-16  1:48   ` Claude review: " Claude Code Review Bot
2026-03-16  1:48 ` Claude review: drm/amd: fix HDMI output with non-HDMI EDID overrides Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260315223307.45807-2-johanneswueller@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox