From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Date: Sun, 22 Mar 2026 05:00:32 +1000 Message-ID: In-Reply-To: <20260318-rimob-new-features-v2-1-c1bf8917449e@protonmail.com> References: <20260318-rimob-new-features-v2-0-c1bf8917449e@protonmail.com> <20260318-rimob-new-features-v2-1-c1bf8917449e@protonmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The binding looks mostly correct. **Issue: `vddam-supply` defined in binding but never used** The binding defines a `vddam-supply` property: ```yaml vddam-supply: description: power supply for MIPI interface ``` But it is not listed in `required`, not used in the driver (patch 2), and n= ot referenced in any DTS node (patch 3). If the hardware genuinely has this= supply but the driver doesn't need to manage it, it could remain optional.= However, it's confusing =E2=80=94 either remove it from the binding or add= support in the driver. The driver's `nt35532_supplies[]` array has `vci`, = `vddi`, `avee`, `avdd` but no `vddam`. Otherwise the binding is clean: `additionalProperties: false`, required pro= perties are sensible, the example is consistent with actual DTS usage. --- Generated by Claude Code Patch Reviewer