Claude review: gpu: nova-core: gsp: move Cmdq's DMA handle to a struct member

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Motivation (sound):** The commit message clearly explains three valid reasons:
1. The accessor is only called once and the value never changes — no need for a method.
2. The method was out of place among message send/receive methods.
3. `pub(crate)` visibility was overly broad; `pub(super)` is tighter.

**Construction change (correct):** The `new()` initializer is refactored from a simple `try_pin_init!` to use `pin_init_scope`, which allows pre-computing `gsp_mem` before consuming it:

```rust
pin_init_scope(move || {
    let gsp_mem = DmaGspMem::new(dev)?;

    Ok(try_pin_init!(Self {
        dma_handle: gsp_mem.0.dma_handle(),
        inner <- new_mutex!(CmdqInner {
            dev: dev.into(),
            gsp_mem,
            seq: 0,
        }),
    }))
})
```

This is the correct pattern — `pin_init_scope` exists exactly for this "compute something, then use it in the initializer" case, as documented in `rust/pin-init/src/lib.rs:1278`. The DMA handle is extracted from `gsp_mem` before `gsp_mem` is moved into `CmdqInner`, which is necessary since you can't borrow after move.

**Caller update (trivial, correct):** In `fw.rs`, the method call `cmdq.dma_handle()` becomes field access `cmdq.dma_handle`:

```rust
sharedMemPhysAddr: cmdq.dma_handle,
```

This is the only call site, confirming the commit message's claim that the method is "effectively only ever called once."

**Visibility narrowing:** Changing from `pub(crate)` to `pub(super)` is a good practice — `fw.rs` is in the same `gsp` module (super), so it retains access, while code outside `gsp` no longer can reach this sensitive DMA address.

**One minor observation:** The `DmaAddress` type is `Copy` (it's used by value in both old and new code without `.clone()`), so storing it as a separate field has no semantic issue — it's just a copied integer/address value, not a second reference to the DMA mapping.

**No issues found.** The patch is clean, well-scoped, and the `pin_init_scope` usage matches the documented pattern.

Reviewed-by assessment: **No objections.**

---
Generated by Claude Code Patch Reviewer