From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add documentation for Sahara protocol. Date: Sun, 22 Mar 2026 04:44:33 +1000 Message-ID: In-Reply-To: <20260319-sahara_protocol_new_v2-v4-1-47ad79308762@oss.qualcomm.com> References: <20260319-sahara_protocol_new_v2-v4-0-47ad79308762@oss.qualcomm.com> <20260319-sahara_protocol_new_v2-v4-1-47ad79308762@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This adds RST documentation under `Documentation/sahara/`. **Issues:** - **Cover letter says "EDITME"** for the v4 changelog. This was not updated= before sending. - **Subject line has trailing period** =E2=80=94 kernel convention omits th= e trailing period. - **Documentation placement**: `Documentation/sahara/` is a top-level direc= tory. This should be under `Documentation/driver-api/` or `Documentation/bu= s/`. The top-level `Documentation/index.rst` is not updated to reference th= is new subtree. - **Multiple typos:** - `SAHARA_MODE_MEMORY_DBEUG` =E2=86=92 should be `DEBUG` - `The Sahar client interprets` =E2=86=92 `Sahara` - `sate machine` =E2=86=92 `state machine` - `targert` =E2=86=92 `target` - `successgul` =E2=86=92 `successful` - `firgure` =E2=86=92 `figure` - **Copy-paste error** in the memory debug section: "The packet flow sequen= ce for image transfer is as follows:" should say "memory debug". - **Copy-paste error in diagram**: Region 2's MEMORY_READ comment says "siz= e of region 0" instead of "size of region 2". --- Generated by Claude Code Patch Reviewer