From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Date: Sun, 22 Mar 2026 04:39:32 +1000 Message-ID: In-Reply-To: <20260319-upstream-6162-v4-1-7268483ef03d@ite.com.tw> References: <20260319-upstream-6162-v4-0-7268483ef03d@ite.com.tw> <20260319-upstream-6162-v4-1-7268483ef03d@ite.com.tw> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The binding looks reasonable overall. **Minor issues:** 1. **Only `port@1` is required, not `port@0`**: This is unusual =E2=80=94 t= ypically `port@0` would be the primary/required port, with `port@1` optiona= l for dual-link mode. If single-DSI mode uses port@0 only, then `port@0` sh= ould be required and `port@1` optional. If the chip truly requires the seco= nd port at minimum, this should be explained in the description. ```yaml required: - port@1 ``` 2. **Missing `port@3` (HDMI output) from required**: An HDMI bridge without= a required output port seems wrong. Most bridge bindings require the outpu= t port. Consider whether `port@3` should also be listed in the ports `requi= red` section. 3. **No `additionalProperties: false`** on the `ports` node itself =E2=80= =94 only on port@0 and port@1 endpoints. This is minor but could allow unex= pected properties in the ports container. --- --- Generated by Claude Code Patch Reviewer