From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel-edp: Add BOE NV153WUM-N42, CMN N153JCA-ELK, CSW MNF307QS3-2 Date: Sun, 22 Mar 2026 04:27:26 +1000 Message-ID: In-Reply-To: <20260319044455.551571-1-alvin1.chen@lcfc.corp-partner.google.com> References: <20260319044455.551571-1-alvin1.chen@lcfc.corp-partner.google.com> <20260319044455.551571-1-alvin1.chen@lcfc.corp-partner.google.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Critical: Double `+` prefix in diff** All three added lines use `++` instead of the single `+` that `git diff` pr= oduces. This means either the patch was manually edited/corrupted, or there= is a literal extra `+` character at the start of each line in the source c= ode: ``` ++ EDP_PANEL_ENTRY('B', 'O', 'E', 0x0db3, &delay_200_500_e80, "NV153WUM-N42= "), ++ EDP_PANEL_ENTRY('C', 'M', 'N', 0x156b, &delay_200_500_e80_d50, "N153JCA-= ELK"), ++ EDP_PANEL_ENTRY('C', 'S', 'W', 0x1529, &delay_200_500_e80_d50, "MNF307QS= 3-2"), ``` If this is a corrupted diff, the patch won't apply. If it somehow does appl= y, the lines would have a leading `+` character in the C source, causing a = compile error. This is likely why the patches could not be applied to the k= ernel tree. **Minor: `Change-Id` tag** ``` Change-Id: I78b81115aa3d52ece04c1e5f88dc1661a2d9305e ``` This is a Gerrit-specific artifact and should be removed before submission = to upstream Linux. **Content review (assuming the `++` is fixed):** - The panel IDs (0x0db3, 0x156b, 0x1529) are correctly sorted in ascending = hex order relative to their neighbors in each manufacturer section =E2=80= =94 verified against the existing entries in the tree. - The delay values chosen (`delay_200_500_e80` for BOE, `delay_200_500_e80_= d50` for CMN and CSW) look reasonable and consistent with similar panels fr= om the same manufacturers. - The commit message includes raw EDID data for each panel, which is good p= ractice for panel-edp additions as it allows reviewers to verify the panel = IDs. - The panel name in the commit message says "CMN N153JCA-ELK" but the code = entry uses the name string `"N153JCA-ELK"` =E2=80=94 this is consistent wit= h CMN naming conventions in the file (CMN entries drop the manufacturer pre= fix in the name string). **Summary:** The patch needs a v3 to fix the corrupted `++` lines and drop = the `Change-Id`. --- Generated by Claude Code Patch Reviewer