From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel-edp: Add BOE NV153WUM-N42, CMN N153JCA-ELK, CSW MNF307QS3-2
Date: Sun, 22 Mar 2026 04:49:58 +1000
Message-ID: <review-patch1-20260319050938.556235-1-alvin1.chen@lcfc.corp-partner.google.com>
In-Reply-To: <20260319050938.556235-1-alvin1.chen@lcfc.corp-partner.google.com>
References: <20260319050938.556235-1-alvin1.chen@lcfc.corp-partner.google.com> <20260319050938.556235-1-alvin1.chen@lcfc.corp-partner.google.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Critical: Malformed diff =E2=80=94 double `+` prefix**

All three added lines use `++` instead of `+` as the diff addition marker:

```
++	EDP_PANEL_ENTRY('B', 'O', 'E', 0x0db3, &delay_200_500_e80, "NV153WUM-N42=
"),
++	EDP_PANEL_ENTRY('C', 'M', 'N', 0x156b, &delay_200_500_e80_d50, "N153JCA-=
ELK"),
++	EDP_PANEL_ENTRY('C', 'S', 'W', 0x1529, &delay_200_500_e80_d50, "MNF307QS=
3-2"),
```

This will cause `git am` / `patch` to fail. Each of these lines should have=
 a single `+` prefix. This is likely why the patches could not be applied t=
o the kernel tree.

**Delay structure choices:**

- **BOE 0x0db3**: Uses `&delay_200_500_e80`. Surrounding BOE entries use a =
mix of `delay_200_500_e50` and `delay_200_500_e80`, so this seems reasonabl=
e but there's no justification in the commit message for why `e80` was chos=
en over `e50`.
- **CMN 0x156b**: Uses `&delay_200_500_e80_d50`. The adjacent CMN entries (=
`0x1565` uses `delay_200_500_e80`, `0x162b` uses `delay_200_500_e80_d50`). =
The choice of `_d50` variant should be justified =E2=80=94 was this determi=
ned from the panel datasheet?
- **CSW 0x1529**: Uses `&delay_200_500_e80_d50`. Adjacent CSW entries use v=
arious delays. Again, no justification provided.

**Panel ID verification from EDID:**

Checking the EDID data against the product codes:
- BOE EDID bytes 8-9: `09 e5` (manufacturer), bytes 10-11: `b3 0d` =E2=86=
=92 product code 0x0db3. Matches.
- CMN EDID bytes 8-9: `0d ae` (manufacturer), bytes 10-11: `6b 15` =E2=86=
=92 product code 0x156b. Matches.
- CSW EDID bytes 8-9: `0e 77` (manufacturer), bytes 10-11: `29 15` =E2=86=
=92 product code 0x1529. Matches.

The panel IDs are correctly extracted from the EDIDs.

**Sorting:** The entries appear to be inserted in the correct sorted order =
by product code within each manufacturer section.

**Summary of issues:**
1. **Must fix:** The `++` prefix on all three added lines is a showstopper =
=E2=80=94 the patch cannot be applied as-is. Resubmit with proper single-`+=
` diff markers.
2. **Nice to have:** The commit message should briefly justify the chosen d=
elay structures (e.g., "delays chosen based on datasheet" or "reusing delay=
s from similar panel model X").

---
Generated by Claude Code Patch Reviewer