From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: rockchip: analogix-dp: Expand clock-names "hclk" for the third clock Date: Sun, 22 Mar 2026 04:26:14 +1000 Message-ID: In-Reply-To: <20260319104031.1986946-2-damon.ding@rock-chips.com> References: <20260319104031.1986946-1-damon.ding@rock-chips.com> <20260319104031.1986946-2-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The change from a fixed `const: grf` to an `enum: [grf, hclk]` for the third clock is correct for allowing both the existing RK3288/RK3399 "grf" clock and the new RK3588/RK3576 "hclk" clock. However, the binding should ideally be more constrained using `allOf`/`if`/`then` blocks to enforce that RK3288/RK3399 use "grf" and RK3588/RK3576 use "hclk", rather than allowing either name on any compatible. As it stands, nothing prevents a DT author from specifying "hclk" on rk3288 or "grf" on rk3588. This is a minor binding correctness concern. The Fixes tag referencing the RK3588 binding addition is appropriate. --- Generated by Claude Code Patch Reviewer