From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: MAINTAINERS: split hisilicon maintenance and add Yongbang Shi for hibmc-drm matainers
Date: Sun, 22 Mar 2026 04:17:00 +1000 [thread overview]
Message-ID: <review-patch1-20260319131132.722033-1-shiyongbang@huawei.com> (raw)
In-Reply-To: <20260319131132.722033-1-shiyongbang@huawei.com>
Patch Review
**Typo in subject:** "matainers" should be "maintainers".
**Critical: Whitespace formatting is wrong.** The MAINTAINERS file uses **tabs** after the field tag (e.g., `M:\t`), as confirmed by the existing file. The patch replaces all tab-separated lines with **spaces**:
```
-M: Xinliang Liu <xinliang.liu@linaro.org>
+M: Yongbang Shi <shiyongbang@huawei.com>
```
The `+` lines use spaces (likely 6 spaces) instead of a tab character. This will cause `scripts/get_maintainer.pl` and checkpatch.pl to complain, and is inconsistent with every other entry in MAINTAINERS. All lines must use a tab after the colon, not spaces.
**Missing F: path trailing slash.** The file path entries lack trailing slashes for directories:
```
+F: drivers/gpu/drm/hisilicon/hibmc
+F: drivers/gpu/drm/hisilicon/kirin
```
The MAINTAINERS convention for directories is to include a trailing `/` (e.g., `F: drivers/gpu/drm/hisilicon/hibmc/`). Without it, `get_maintainer.pl` may not match files within the directory correctly. The existing entry uses `F: drivers/gpu/drm/hisilicon/` with a trailing slash.
**Documentation/devicetree/bindings coverage.** The DT bindings path `Documentation/devicetree/bindings/display/hisilicon/` is only assigned to the KIRIN section. If hibmc also has (or will have) DT bindings under that path, they would have no maintainer coverage. Currently this seems reasonable since hibmc is a BMC (server management) driver that likely doesn't use DT, but it's worth confirming.
**Tian Tao remains M: for HIBMC but was removed from original entry in V1→V2 changelog context.** The changelog says "remove Tian Tao and Xinwei Kong from DRM DRIVERS FOR HISILICON KIRIN," and indeed they are only listed under HIBMC. This seems intentional and fine — just noting for clarity.
**Summary of required fixes:**
1. Fix subject typo: "matainers" → "maintainers"
2. Use tabs (not spaces) after field tags on all new lines
3. Add trailing `/` to directory paths in `F:` entries (`hibmc/`, `kirin/`)
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 13:11 [PATCH V2 for drm-misc-fixes] MAINTAINERS: split hisilicon maintenance and add Yongbang Shi for hibmc-drm matainers Yongbang Shi
2026-03-21 18:17 ` Claude Code Review Bot [this message]
2026-03-21 18:17 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260319131132.722033-1-shiyongbang@huawei.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox