From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: MAINTAINERS: split hisilicon maintenance and add Yongbang Shi for hibmc-drm matainers Date: Sun, 22 Mar 2026 04:17:00 +1000 Message-ID: In-Reply-To: <20260319131132.722033-1-shiyongbang@huawei.com> References: <20260319131132.722033-1-shiyongbang@huawei.com> <20260319131132.722033-1-shiyongbang@huawei.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Typo in subject:** "matainers" should be "maintainers". **Critical: Whitespace formatting is wrong.** The MAINTAINERS file uses **t= abs** after the field tag (e.g., `M:\t`), as confirmed by the existing file= . The patch replaces all tab-separated lines with **spaces**: ``` -M: Xinliang Liu +M: Yongbang Shi ``` The `+` lines use spaces (likely 6 spaces) instead of a tab character. This= will cause `scripts/get_maintainer.pl` and checkpatch.pl to complain, and = is inconsistent with every other entry in MAINTAINERS. All lines must use a= tab after the colon, not spaces. **Missing F: path trailing slash.** The file path entries lack trailing sla= shes for directories: ``` +F: drivers/gpu/drm/hisilicon/hibmc +F: drivers/gpu/drm/hisilicon/kirin ``` The MAINTAINERS convention for directories is to include a trailing `/` (e.= g., `F: drivers/gpu/drm/hisilicon/hibmc/`). Without it, `get_maintainer.pl`= may not match files within the directory correctly. The existing entry use= s `F: drivers/gpu/drm/hisilicon/` with a trailing slash. **Documentation/devicetree/bindings coverage.** The DT bindings path `Docum= entation/devicetree/bindings/display/hisilicon/` is only assigned to the KI= RIN section. If hibmc also has (or will have) DT bindings under that path, = they would have no maintainer coverage. Currently this seems reasonable sin= ce hibmc is a BMC (server management) driver that likely doesn't use DT, bu= t it's worth confirming. **Tian Tao remains M: for HIBMC but was removed from original entry in V1= =E2=86=92V2 changelog context.** The changelog says "remove Tian Tao and Xi= nwei Kong from DRM DRIVERS FOR HISILICON KIRIN," and indeed they are only l= isted under HIBMC. This seems intentional and fine =E2=80=94 just noting fo= r clarity. **Summary of required fixes:** 1. Fix subject typo: "matainers" =E2=86=92 "maintainers" 2. Use tabs (not spaces) after field tags on all new lines 3. Add trailing `/` to directory paths in `F:` entries (`hibmc/`, `kirin/`) --- Generated by Claude Code Patch Reviewer