From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing()
Date: Sun, 22 Mar 2026 04:12:40 +1000 [thread overview]
Message-ID: <review-patch1-20260319164833.409126-2-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260319164833.409126-2-biju.das.jz@bp.renesas.com>
Patch Review
This moves `rzg2l_mipi_dsi_set_display_timing()` from `atomic_pre_enable` to `atomic_enable`, placing it after `rzg2l_mipi_dsi_start_hs_clock()`. The hardware manual requires display timings to be set after HS clock is started.
**Issue: Silent dropping of error handling for rzg2l_mipi_dsi_startup()**
In the original code:
```c
ret = rzg2l_mipi_dsi_startup(dsi, mode);
if (ret < 0)
return;
```
The patch changes this to:
```c
rzg2l_mipi_dsi_startup(dsi, mode);
```
`rzg2l_mipi_dsi_startup()` returns an int and can fail (e.g., `pm_runtime_resume_and_get()`, `dphy_init()`, `dphy_conf_clks()` can all return errors). Silently ignoring the return value means that if startup fails, the driver will proceed to `atomic_enable` and attempt to start the HS clock on uninitialized hardware. The commit message mentions "Drop the unused ret variable" but `ret` was being *used* for error checking — it just couldn't propagate the error since the bridge callback returns void. Still, the early return prevented further damage. This should be preserved:
```c
if (rzg2l_mipi_dsi_startup(dsi, mode) < 0)
return;
```
**Duplicated connector/crtc/mode lookup:** The mode lookup code is now duplicated in both `atomic_pre_enable` and `atomic_enable`. Consider caching the mode pointer in `struct rzg2l_mipi_dsi` during `atomic_pre_enable` to avoid the duplication, though this is a minor style point.
Otherwise the fix itself is correct per the hardware manual requirements.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 16:48 [PATCH v2 0/4] Improvements on RZ/G2L MIPI DSI driver Biju
2026-03-19 16:48 ` [PATCH v2 1/4] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Biju
2026-03-21 18:12 ` Claude Code Review Bot [this message]
2026-03-19 16:48 ` [PATCH v2 2/4] drm: renesas: rzg2l_mipi_dsi: Fix assert of CMN_RSTB signal Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 3/4] drm: renesas: rzg2l_mipi_dsi: Fix deassert " Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 4/4] drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay to 1 msec Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-21 18:12 ` Claude review: Improvements on RZ/G2L MIPI DSI driver Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260319164833.409126-2-biju.das.jz@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox