From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: convert PMC registers to kernel register macro
Date: Sun, 22 Mar 2026 03:45:04 +1000 [thread overview]
Message-ID: <review-patch1-20260320-b4-nova-register-v2-1-88fcf103e8d4@nvidia.com> (raw)
In-Reply-To: <20260320-b4-nova-register-v2-1-88fcf103e8d4@nvidia.com>
Patch Review
The commit message mentions introducing `nv_reg` macro, but per v2 changelog this was dropped. The commit message should be updated to remove the `nv_reg` reference:
> nova-core's registers have some constant properties (like a 32-bit size
> and a crate visibility), so introduce the `nv_reg` macro to shorten
> their declaration.
This text is stale from v1.
In `regs.rs`, the `Display` impl for `NV_PMC_BOOT_42` uses `self.inner`:
```rust
self.inner,
```
while the `architecture_raw` method uses `self.into_raw()`:
```rust
((self.into_raw() >> Self::ARCHITECTURE_RANGE.start())
```
This is inconsistent. Since `into_raw()` is the proper accessor pattern for the kernel register macro, `self.inner` should likely also be `self.into_raw()`. However, this depends on whether the kernel macro exposes `inner` as a public field -- it may do so, but using `into_raw()` would be more consistent. Since I can't verify the kernel macro's API (it's on drm-rust-next, not drm-next), this is a potential issue worth flagging.
The `From<Architecture> for Bounded<u32, 6>` impl is more verbose than the old `repr(u8)` cast but is required by the new type system. The `Bounded::new::<CONST>()` pattern is clear.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 12:19 [PATCH v2 00/10] gpu: nova-core: convert registers to use the kernel register macro Alexandre Courbot
2026-03-20 12:19 ` [PATCH v2 01/10] gpu: nova-core: convert PMC registers to " Alexandre Courbot
2026-03-20 19:09 ` Gary Guo
2026-03-21 17:45 ` Claude Code Review Bot [this message]
2026-03-20 12:19 ` [PATCH v2 02/10] gpu: nova-core: convert PBUS " Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 12:19 ` [PATCH v2 03/10] gpu: nova-core: convert PFB " Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 12:19 ` [PATCH v2 04/10] gpu: nova-core: convert GC6 " Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 12:19 ` [PATCH v2 05/10] gpu: nova-core: convert FUSE " Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 12:19 ` [PATCH v2 06/10] gpu: nova-core: convert PDISP " Alexandre Courbot
2026-03-20 17:33 ` Joel Fernandes
2026-03-21 6:19 ` Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 12:19 ` [PATCH v2 07/10] gpu: nova-core: falcon: introduce `bounded_enum` macro Alexandre Courbot
2026-03-20 19:08 ` Gary Guo
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 12:19 ` [PATCH v2 08/10] gpu: nova-core: convert falcon registers to kernel register macro Alexandre Courbot
2026-03-20 17:38 ` Joel Fernandes
2026-03-20 19:52 ` John Hubbard
2026-03-20 20:07 ` Danilo Krummrich
2026-03-20 20:23 ` Gary Guo
2026-03-20 20:17 ` Gary Guo
2026-03-21 6:16 ` Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 12:19 ` [PATCH v2 09/10] gpu: nova-core: remove `io::` qualifier to register macro invocations Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 12:19 ` [PATCH v2 10/10] Documentation: nova: remove register abstraction task Alexandre Courbot
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
2026-03-20 19:11 ` [PATCH v2 00/10] gpu: nova-core: convert registers to use the kernel register macro Gary Guo
2026-03-21 17:45 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-23 11:07 [PATCH v3 00/10] " Alexandre Courbot
2026-03-23 11:07 ` [PATCH v3 01/10] gpu: nova-core: convert PMC registers to " Alexandre Courbot
2026-03-24 21:57 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260320-b4-nova-register-v2-1-88fcf103e8d4@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox