From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: simplify remote pointer management using __free Date: Sun, 22 Mar 2026 03:48:37 +1000 Message-ID: In-Reply-To: <20260320-drm-lcdif-dbanc-v1-1-479a04133e70@bootlin.com> References: <20260320-drm-lcdif-dbanc-v1-0-479a04133e70@bootlin.com> <20260320-drm-lcdif-dbanc-v1-1-479a04133e70@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Bug: Wrong cleanup specifier.** The patch uses `__free(drm_bridge_put)` o= n a `struct device_node *`: ```c struct device_node *remote __free(drm_bridge_put) =3D of_graph_get_remote_port_parent(ep); ``` `drm_bridge_put` is defined for `struct drm_bridge *` (see `include/drm/drm= _bridge.h:1295`), not `struct device_node *`. This should be `__free(device= _node)` which calls `of_node_put()` =E2=80=94 matching what the original co= de did manually. As-is, this would either fail to compile (type mismatch) o= r invoke undefined behavior. The simplification logic itself is correct =E2=80=94 the two manual `of_nod= e_put(remote)` calls are properly replaced by the auto-cleanup. --- Generated by Claude Code Patch Reviewer