public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu/userq: convert comma to semicolon
Date: Sun, 22 Mar 2026 03:50:50 +1000	[thread overview]
Message-ID: <review-patch1-20260320083247.428482-1-nichen@iscas.ac.cn> (raw)
In-Reply-To: <20260320083247.428482-1-nichen@iscas.ac.cn>

Patch Review

**Assessment: Low-priority cleanup, technically correct**

The two changed lines (lines 964 and 971 of the original file) both have the pattern:

```c
ptr = u64_to_user_ptr(wait_info->bo_read_handles),
```

changed to:

```c
ptr = u64_to_user_ptr(wait_info->bo_read_handles);
```

The trailing `,` makes the assignment part of a comma expression, but since the next statement is on a separate line and the comma's result (the value of `ptr`) is discarded, there is no behavioral difference. The fix is correct — semicolons are the intended statement terminators here, and the commas were likely typos (possibly from copy-paste of an initializer list or similar).

**Minor observations:**
- The commit message is fine and accurately describes the change as having no functional impact.
- "Compile tested only" is acceptable for this type of change, though runtime testing would always be preferred for driver code.
- The "Found by inspection" note is honest but also a hallmark of low-value automated/mechanical cleanup patches. Maintainers may or may not care to take these.

**Verdict:** Correct but trivial. No objections to merging, but also no urgency.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-21 17:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20  8:32 [PATCH] drm/amdgpu/userq: convert comma to semicolon Chen Ni
2026-03-21 17:50 ` Claude review: " Claude Code Review Bot
2026-03-21 17:50 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260320083247.428482-1-nichen@iscas.ac.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox